launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #31080
Re: [Merge] ~ines-almeida/launchpad:fetch-service-add-missing-fetch-service-args into launchpad:master
It looks like that as a minimum we need to add the new arg to the `BuildArgs` class in buildfarmjobbehaviour.py.
Additionally, I would love to see an additional or updated test related to this code change.
Also, how did you notice the missing arg? This might be valuable information to avoid similar issues in the future, as we need to add new build types in the next cycle.
--
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/465003
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/launchpad:fetch-service-add-missing-fetch-service-args into launchpad:master.
References