launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] ~ines-almeida/launchpad:fetch-service-add-missing-fetch-service-args into launchpad:master

To: Ines Almeida <ines.almeida@xxxxxxxxxxxxx>
From: Ines Almeida <mp+465003@xxxxxxxxxxxxxxxxxx>
Date: Fri, 26 Apr 2024 08:59:35 -0000
In-reply-to: <171406441949.3386235.2305741366909173040.launchpad@juju-98d295-prod-launchpad-17>
Reply-to: mp+465003@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

Updated (still squashed into 1 commit since it was just a 1-liner)

This was a very quick MP that I opened right before the EOD to get it out of the way, it isn't blocking any testingas I cowboyed it in qastaging.

As fornoticing the missing arg, I simply noticed some code wasn't running in buildd, and I checked the build logs to find that this expected arg wasn't there. Adding it fixed the initial issue.
-- 
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/465003
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/launchpad:fetch-service-add-missing-fetch-service-args into launchpad:master.

References

[Merge] ~ines-almeida/launchpad:fetch-service-add-missing-fetch-service-args into launchpad:master
From: Ines Almeida, 2024-04-25