launchpad-reviewers team mailing list archive

[Jürgen Gmach <mp+467916@xxxxxxxxxxxxxxxxxx>]

I think the commit message could be improved a bit.

First, you mention this commit does two things, but when I look at the code, it does three.

- bumping the revision
- changing the snap channel (not mentioned at all)
- configure the log file name

My first question would be... are these three changes directly connected to each other?

If not, split the commits.

If yes, try to summarize the big picture.

What does this merge proposal do? Why did you create it in the first place?

Is the gist of your changes to configure logging properly?

Then a good commit message would be:

```
lp-fetch-service: configure logging


Configure name for a log file

(then add a reason why we need to do this)

This change also requires to bump the charm revision and to switch to the `latest/candidate` channel.

(maybe you could even link to where channel-to-environment mappings are defined?)
```


-- 
https://code.launchpad.net/~pelpsi/launchpad-mojo-specs/+git/private/+merge/467916
Your team Launchpad code reviewers is subscribed to branch ~launchpad/launchpad-mojo-specs/+git/private:master.