launchpad-reviewers team mailing list archive

[Simone Pelosi <mp+471715@xxxxxxxxxxxxxxxxxx>]

Simone Pelosi has proposed merging ~pelpsi/launchpad-buildd:nofile-limit-buildd into launchpad-buildd:master.

Commit message:
Add LimitNOFILE configuration to launchpad-buildd deamon
    
This configuration is required since we are hitting the default limit 1024
in most of our builds. There was also an issue with npm that fails if it cannot
open new file descriptors causing builds failing.


Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~pelpsi/launchpad-buildd/+git/launchpad-buildd/+merge/471715
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~pelpsi/launchpad-buildd:nofile-limit-buildd into launchpad-buildd:master.

diff --git a/debian/changelog b/debian/changelog
index 279100f..8ef52e8 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -3,6 +3,9 @@ launchpad-buildd (241) UNRELEASED; urgency=medium
     [ Quentin Debhi ]
     * Add rockcraft build type.
 
+    [ Simone Pelosi ]
+    * Add LimitNOFILE configuration to launchpad-buildd deamon.
+
  -- Quentin Debhi <quentin.debhi@xxxxxxxxxxxxx>  Wed, 07 Aug 2024 16:33:34 +0200
 
 launchpad-buildd (240) focal; urgency=medium
diff --git a/debian/launchpad-buildd@.service b/debian/launchpad-buildd@.service
index 23cc469..ad0b6c0 100644
--- a/debian/launchpad-buildd@.service
+++ b/debian/launchpad-buildd@.service
@@ -25,6 +25,7 @@ ExecStart=/usr/bin/twistd3 --no_save --pidfile /run/launchpad-buildd/%i.pid --py
 # If the machine runs out of memory, killing just about any other process is
 # better than killing launchpad-buildd.
 OOMScoreAdjust=-1000
+LimitNOFILE=65536
 
 [Install]
 WantedBy=multi-user.target