launchpad-reviewers team mailing list archive

[Yuliy Schwartzburg <mp+473730@xxxxxxxxxxxxxxxxxx>]

Yuliy Schwartzburg has proposed merging ~ikoruk/launchpad-buildd:git-protocol-v2 into launchpad-buildd:master.

Commit message:
For fetch service we should enable git protocol v2 since currently v1 is not supported. This environment variable enables v2 for the git supplied with focal.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~ikoruk/launchpad-buildd/+git/launchpad-buildd/+merge/473730
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ikoruk/launchpad-buildd:git-protocol-v2 into launchpad-buildd:master.

diff --git a/lpbuildd/target/proxy.py b/lpbuildd/target/proxy.py
index bc019b5..9350f66 100644
--- a/lpbuildd/target/proxy.py
+++ b/lpbuildd/target/proxy.py
@@ -106,6 +106,8 @@ class BuilderProxyOperationMixin:
             # Avoid needing to keep track of snap store CDNs in proxy
             # configuration.
             full_env["SNAPPY_STORE_NO_CDN"] = "1"
+        if use_fetch_service:
+            full_env["GIT_PROTOCOL"] = "version=2"
         # Avoid circular import using __class__.__name__
         if use_fetch_service and self.__class__.__name__ == "BuildRock":
             full_env["CARGO_HTTP_CAINFO"] = self.mitm_certificate_path