launchpad-reviewers team mailing list archive

[Jürgen Gmach <mp+473730@xxxxxxxxxxxxxxxxxx>]

We usually use a line length of ~79 for git commit messages, to avoid scrolling horizontally.

I would love to have a reference to where it is mentioned that with this env variable you can actually set the git protocol.

Most resources I found only showed the `git config..` way, e.g. https://docs.gitlab.com/ee/administration/git_protocol.html#instructions - review would be easier with a link to some (official) documentation.

The commit message mentions focal, but nowhere in the changed code focal appears. I am aware why this is that way, as I was part in some discussions, but we should add some more context, best case both as a comment to the code and in the commit message. We should also add a note that this does not fix the issue for < focal.

And last.. it looks like only one test case for rocks needed to be updated. That indicates we have a missing test case for snaps. That is not part of this MP, but we should create it afterwards, or at least create a Jira ticket.
-- 
https://code.launchpad.net/~ikoruk/launchpad-buildd/+git/launchpad-buildd/+merge/473730
Your team Launchpad code reviewers is requested to review the proposed merge of ~ikoruk/launchpad-buildd:git-protocol-v2 into launchpad-buildd:master.