launchpad-reviewers team mailing list archive

[Tushar Gupta <mp+480702@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/archivepublisher/scripts/publishdistro.py b/lib/lp/archivepublisher/scripts/publishdistro.py
> index 33982d8..fe9e002 100644
> --- a/lib/lp/archivepublisher/scripts/publishdistro.py
> +++ b/lib/lp/archivepublisher/scripts/publishdistro.py
> @@ -646,10 +646,8 @@ class PublishDistro(PublisherScript):
>          exclude_options = []
>          # If there are any archives specified to be excluded, exclude rsync
>          # for them in the rsync command
> -        for excluded_archive in self.findArchives(
> -            self.options.excluded_archives
> -        ):
> -            exclude_options.extend(["--exclude", excluded_archive.reference])
> +        for excluded_archive_reference in self.options.excluded_archives:

We don't need*

> +            exclude_options.extend(["--exclude", excluded_archive_reference])
>          return [
>              self._buildRsyncCommand(
>                  extra_options=exclude_options,


-- 
https://code.launchpad.net/~tushar5526/launchpad/+git/launchpad/+merge/480702
Your team Launchpad code reviewers is requested to review the proposed merge of ~tushar5526/launchpad:bug-fixes-and-optimisations-for-archive-and-exclude-options into launchpad:master.