launchpad-reviewers team mailing list archive

[Simone Pelosi <mp+480779@xxxxxxxxxxxxxxxxxx>]

Simone Pelosi has proposed merging ~pelpsi/launchpad:fix-snapbuildjob-failing-test into launchpad:master.

Commit message:
Snap build name should be dynamic.


Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~pelpsi/launchpad/+git/launchpad/+merge/480779
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~pelpsi/launchpad:fix-snapbuildjob-failing-test into launchpad:master.

diff --git a/lib/lp/snappy/tests/test_snapbuildjob.py b/lib/lp/snappy/tests/test_snapbuildjob.py
index b3b63be..63d0248 100644
--- a/lib/lp/snappy/tests/test_snapbuildjob.py
+++ b/lib/lp/snappy/tests/test_snapbuildjob.py
@@ -374,7 +374,8 @@ class TestSnapStoreUploadJob(TestCaseWithFactory):
         self.assertIsNone(job.error_message)
         self.assertEqual([], pop_notifications())
         self.assertIn(
-            "[SnapStoreUploadJob] Pushing build snap-name-100030 with id 1.",
+            "[SnapStoreUploadJob] Pushing build %s with id 1."
+            % snapbuild.snap.name,
             logger.output,
         )
         self.assertIn(