launchpad-reviewers team mailing list archive

[Vaishnavi Asawale <mp+490593@xxxxxxxxxxxxxxxxxx>]

Vaishnavi Asawale has proposed merging ~vaishnavi-asawale/launchpad:fix-fetch-service-required into launchpad:master.

Commit message:
Revert change that made fetch_service_policy required


The fetch_service_policy was set to be required in a previous commit
and led to issues in creating snaps using the API. The fetch_service_policy
has to be required only for the Snap Edit UI, therefore, the change making
it globally required needs to be reverted.


Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~vaishnavi-asawale/launchpad/+git/launchpad/+merge/490593
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~vaishnavi-asawale/launchpad:fix-fetch-service-required into launchpad:master.

diff --git a/lib/lp/snappy/interfaces/snap.py b/lib/lp/snappy/interfaces/snap.py
index 9672734..98b11bb 100644
--- a/lib/lp/snappy/interfaces/snap.py
+++ b/lib/lp/snappy/interfaces/snap.py
@@ -1156,7 +1156,7 @@ class ISnapEditableAttributes(IHasOwner):
         Choice(
             title=_("Fetch service policy"),
             vocabulary=FetchServicePolicy,
-            required=True,
+            required=False,
             readonly=False,
             default=FetchServicePolicy.STRICT,
             description=_(