launchpad-reviewers team mailing list archive

[Enrique Sánchez <mp+493398@xxxxxxxxxxxxxxxxxx>]

Changes look good, left a question. Will re review once todos are implemented :)

Diff comments:

> diff --git a/lib/lp/bugs/scripts/svthandler.py b/lib/lp/bugs/scripts/svthandler.py
> index 9e9d096..9907105 100644
> --- a/lib/lp/bugs/scripts/svthandler.py
> +++ b/lib/lp/bugs/scripts/svthandler.py
> @@ -20,6 +20,10 @@ class SVTRecord:
>          """Parse a string and return a SVTRecord."""
>          raise NotImplementedError()
>  
> +    def to_yaml(self) -> str:

why would we want a `to_yaml` here? We are not sure that every cve file will use yaml. Indeed UCT does not.

> +        """Convert the SVTRecord to a YAML string."""
> +        raise NotImplementedError()
> +
>  
>  class SVTImporter:
>      def from_record(


-- 
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/493398
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/launchpad:uct-export-handler into launchpad:master.