launchpad-reviewers team mailing list archive

[Ines Almeida <mp+493398@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/bugs/scripts/svthandler.py b/lib/lp/bugs/scripts/svthandler.py
> index 9e9d096..9907105 100644
> --- a/lib/lp/bugs/scripts/svthandler.py
> +++ b/lib/lp/bugs/scripts/svthandler.py
> @@ -20,6 +20,10 @@ class SVTRecord:
>          """Parse a string and return a SVTRecord."""
>          raise NotImplementedError()
>  
> +    def to_yaml(self) -> str:

Whatever methods are expected to be used by classes that inherit from this "interface" should be here, and currently the `ExportVulnerabilityJob.run()` method expects a `to_yaml()` to export the records.
Either we define this `to_yaml` as something that all handlers need and add it to the new UCT handler, or we define some other method to do that (in both cases, we should add it here as the place where we keep track of the methods all handlers need)

> +        """Convert the SVTRecord to a YAML string."""
> +        raise NotImplementedError()
> +
>  
>  class SVTImporter:
>      def from_record(


-- 
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/493398
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/launchpad:uct-export-handler into launchpad:master.