launchpad-reviewers team mailing list archive

[Ines Almeida <mp+493451@xxxxxxxxxxxxxxxxxx>]

I think the change to use a regular dict (which the CVSS follows) instead of CVSS makes sense (things look simpler!), but why the change on `discovered_by` on tests?

I think one thing that's missing is adding a couple of tests for the permission changes

Diff comments:

> diff --git a/lib/lp/bugs/scripts/uct/tests/test_uct.py b/lib/lp/bugs/scripts/uct/tests/test_uct.py
> index 7b022c0..a1e07f1 100644
> --- a/lib/lp/bugs/scripts/uct/tests/test_uct.py
> +++ b/lib/lp/bugs/scripts/uct/tests/test_uct.py
> @@ -335,7 +324,7 @@ class TestCVE(TestCaseWithFactory):
>              ),
>              public_date=datetime(2022, 1, 14, 8, 15, tzinfo=timezone.utc),
>              description="description",
> -            discovered_by="tr3e wang",
> +            discovered_by="",

Why did this field change in the test?

>              mitigation="mitigation",
>              notes="author> text",
>              priority=UCTRecord.Priority.CRITICAL,


-- 
https://code.launchpad.net/~enriqueesanchz/launchpad/+git/launchpad/+merge/493451
Your team Launchpad code reviewers is requested to review the proposed merge of ~enriqueesanchz/launchpad:add-metadata-cve-model into launchpad:master.