← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] ~enriqueesanchz/launchpad:add-metadata-cve-model into launchpad:master

 

> but why the change on `discovered_by`

`discovered_by` was being stored in the `Cve` class, overwriting the imported cve from MITRE (LP182 said that it was fine, now that we know more about the domain, we know it shouldn't be there). We should create a ticket to find where to place it.

> I think one thing that's missing is adding a couple of tests for the
> permission changes

Agree, will add it :)

I'm still trying to find a way to make `sequence` read only
-- 
https://code.launchpad.net/~enriqueesanchz/launchpad/+git/launchpad/+merge/493451
Your team Launchpad code reviewers is requested to review the proposed merge of ~enriqueesanchz/launchpad:add-metadata-cve-model into launchpad:master.



References