launchpad-users team mailing list archive

[Gianfranco Costamagna <costamagnagianfranco@xxxxxxxx>]

Let's start:

1) debian/rules is full of useless stuff.

%:
        dh $@

override_dh_auto_build:
        xsltproc --nonet --param man.charmap.use.subset 0 -o docs/ http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl docs/make-test-release.1.xml
        dh_auto_build

is more than enough.

2) lines can't be more than 80 char long (copyright and control)
3) control file: debhelper >=9, not 9.0.0 (it might be correct, but I think >=9 is better)
4) arch: "any", no, you seem to build an arch independent package, you don't build anything, so your arch is "all", the same package for all architectures
5) debian/dirs is useless, install file automagically creates directories
6) xsltproc --nonet --param man.charmap.use.subset 0 -o docs/ http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl docs/make-test-release.1.xml

why did you create this file if you don't install it anywhere?

7) after correcting all of them, (debian directory attached)
there still are _many_ lintian warnings, I leave to you to correct

P.S. please correct debian/source/format back to quilt, I changed it for building locally and forgot to change it again (yes I could have used fakeroot indeed)

lintian ../make-test-release_1.2_amd64.changes 
N: Using profile ubuntu/main.
N: Setting up lab in /tmp/temp-lintian-lab-mPs8RuA_JT ...
N: Unpacking packages in group make-test-release/1.2
N: ----
N: Processing changes file make-test-release (version 1.2, arch source all) ...
N: ----
N: Processing source package make-test-release (version 1.2, arch source) ...
W: make-test-release source: debhelper-but-no-misc-depends make-test-release
N: 
N:    The source package uses debhelper, but it does not include
N:    ${misc:Depends} in the given binary package's debian/control entry. Any
N:    debhelper command may add dependencies to ${misc:Depends} that are
N:    required for the work that it does, so recommended best practice is to
N:    always add ${misc:Depends} to the dependencies of each binary package if
N:    debhelper is in use.
N:    
N:    Refer to the debhelper(7) manual page for details.
N:    
N:    Severity: normal, Certainty: possible
N:    
N:    Check: debhelper, Type: source
N: 
N: ----
N: Processing binary package make-test-release (version 1.2, arch all) ...
W: make-test-release: description-synopsis-starts-with-article
N: 
N:    The first line of the "Description:" should omit any initial indefinite
N:    or definite article: "a", "an", or "the". A good heuristic is that it
N:    should be possible to substitute the package name and synopsis into this
N:    formula:
N:    
N:    The package name provides {a,an,the,some} synopsis.
N:    
N:    Refer to Debian Developer's Reference section 6.2.2 (The package
N:    synopsis, or short description) for details.
N:    
N:    Severity: minor, Certainty: certain
N:    
N:    Check: description, Type: binary, udeb
N: 
I: make-test-release: spelling-error-in-manpage usr/share/man/man1/make-test-release.1.gz choosen chosen
N: 
N:    Lintian found a spelling error in the manpage. Lintian has a list of
N:    common misspellings that it looks for. It does not have a dictionary
N:    like a spelling checker does.
N:    
N:    If the string containing the spelling error is translated with the help
N:    of gettext (with the help of po4a, for example) or a similar tool,
N:    please fix the error in the translations as well as the English text to
N:    avoid making the translations fuzzy. With gettext, for example, this
N:    means you should also fix the spelling mistake in the corresponding
N:    msgids in the *.po files.
N:    
N:    Severity: minor, Certainty: possible
N:    
N:    Check: manpages, Type: binary
N: 
I: make-test-release: spelling-error-in-manpage usr/share/man/man1/make-test-release.1.gz choosen chosen
W: make-test-release: binary-without-manpage usr/bin/switch-chroot-precise
N: 
N:    Each binary in /usr/bin, /usr/sbin, /bin, /sbin or /usr/games should
N:    have a manual page
N:    
N:    Note that though the man program has the capability to check for several
N:    program names in the NAMES section, each of these programs should have
N:    its own manual page (a symbolic link to the appropriate manual page is
N:    sufficient) because other manual page viewers such as xman or tkman
N:    don't support this.
N:    
N:    If the name of the man page differs from the binary by case, man may be
N:    able to find it anyway; however, it is still best practice to make the
N:    case of the man page match the case of the binary.
N:    
N:    If the man pages are provided by another package on which this package
N:    depends, lintian may not be able to determine that man pages are
N:    available. In this case, after confirming that all binaries do have man
N:    pages after this package and its dependencies are installed, please add
N:    a lintian override.
N:    
N:    Refer to Debian Policy Manual section 12.1 (Manual pages) for details.
N:    
N:    Severity: normal, Certainty: possible
N:    
N:    Check: manpages, Type: binary
N: 
W: make-test-release: binary-without-manpage usr/bin/switch-chroot-trusty
W: make-test-release: binary-without-manpage usr/bin/switch-chroot-utopic
E: make-test-release: shell-script-fails-syntax-check usr/bin/make-test-release
N: 
N:    Running this shell script with the shell's -n option set fails, which
N:    means that the script has syntax errors. The most common cause of this
N:    problem is a script expecting /bin/sh to be bash checked on a system
N:    using dash as /bin/sh.
N:    
N:    Run e.g. sh -n yourscript to see the errors yourself.
N:    
N:    Note this can have false-positives, for an example with bash scripts
N:    using "extglob".
N:    
N:    Severity: important, Certainty: possible
N:    
N:    Check: scripts, Type: binary
N: 


cheers,

G.

Attachment: debian.tar.gz
Description: GNU Zip compressed data