← Back to team overview

lazr-users team mailing list archive

Re: lazr-js build broken

 

On November 16, 2009, Michael Nelson wrote:
> On Mon, Nov 16, 2009 at 7:16 AM, Paul Hummer 
<paul@xxxxxxxxxxxxxxxxxxxx>wrote:
> > On Mon, 16 Nov 2009 07:05:48 -0600
> >
> > Michael Nelson <michael.nelson@xxxxxxxxxxxxx> wrote:
> > > Hrm, the new js parsing is falling over on something I've added in the
> > > error.js.
> > >
> > > I'll try to take a look after brekkie if someone hasn't gotten there
> >
> > first.
> >
> >
> > The problem is the very last of the error.js module.  Sidnei changed it
> > so that
> > we actually parse the js as json, so we need to use double quotes in the
> > version and requires properties.  If you change them to double quotes,
> > you should be good to go.
> >
> > I should have mentioned that when I reviewed Michael's branch, but I
> > completely
> > forgot.
> 
> Thanks Paul. I've pushed and created an MP with jtv as the reviewer at:
> 
> https://code.edge.launchpad.net/~michael.nelson/lazr-js/error_build_issue/+
> merge/14911
> 
> but he's probably asleep, so if anyone else wants to give it an RS I'll
>  land it :)
> 

Done.

-- 
Francis J. Lacoste
francis.lacoste@xxxxxxxxxxxxx

Attachment: signature.asc
Description: This is a digitally signed message part.


References