linuxdcpp-team team mailing list archive

["Marc A. Donges" <kosh@xxxxxxxxx>]

Public bug reported:

Priority: wishlist

linuxdcpp should not unconditionally fsync() finished downloads. Calling
fsync() on large files is a huge burden on an interactive system. The
use of fsync() after a download has finished should at least be
configurable.

Also, seriously, why does this function

size_t File::flush() throw(FileException) {
        if(isOpen() && fsync(h) == -1)
                throw FileException(Util::translateError(errno));
        return 0;
}

return a size_t? It always returns 0 or throws an exception, so it could
just as well be void.

** Affects: linuxdcpp
     Importance: Undecided
         Status: New

-- 
linuxdcpp should not unconditionally fsync() finished downloads
https://bugs.launchpad.net/bugs/510493
You received this bug notification because you are a member of LinuxDC++
Team, which is subscribed to LinuxDC++.

Status in Linux DC++: New

Bug description:
Priority: wishlist

linuxdcpp should not unconditionally fsync() finished downloads. Calling fsync() on large files is a huge burden on an interactive system. The use of fsync() after a download has finished should at least be configurable.

Also, seriously, why does this function

size_t File::flush() throw(FileException) {
        if(isOpen() && fsync(h) == -1)
                throw FileException(Util::translateError(errno));
        return 0;
}

return a size_t? It always returns 0 or throws an exception, so it could just as well be void.