linuxdcpp-team team mailing list archive

[Crise <markuwil@xxxxxxxxx>]

Short answer: not directly...

Long answer: It doesn't support them right now directly... because the
listeners use so many C++ specific features it was easier just to expose
select listeners through hooks also it allows more precise control over
what info plugin has access to.

There is a way to add full support for this in theory but I am not sure
how much work that would actually be as it would essentially mean
turning or hook subscriber into an universal listener. Also when DC++
fires an event most of the time the a, b and c are something that can
not be used by a plugin directly, because plugins do not know DC++
internal types. So it would also be necessary to be able to wrap any
object members we want plugins to have access to into structs etc.

This is what is essentially done for the listeners exposed to plugins
right now.

If we give up on the API being pure C then this comes notably easier but
still not necessarily easy.

-- 
Plugins support
https://bugs.launchpad.net/bugs/587597
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.

Status in DC++: New

Bug description:
Ok, I'll leave out the sales pitch... here is a potential patch for adding support for plugins to DC++, compiles cleanly (ie. shouldn't generate any warnings) under mingw and visual studio of course and has been tested and working.

The code itself has been in ApexDC++ for a while so it has gotten real life use as well, of course migrating it to clean DC++ needed a few changes here and there but nothing major.

Should also compile and work on linux as it is... but this I have not had chance to test at all so that is just on paper for now.

The major difference between this patch and what's in ApexDC++ is that it does not include a full settings page for plugins which ApexDC++ has. This is simply because I don't know a squat about DWT. Instead this patch has set of chat commands added, so you can play around with the plugins, but if this gets accepted then I certainly hope someone is willing to invest into a settings page for usability sake.

Oh and few changes to the code come directly from bcdcpp, you'll spot them I am sure :).

As for the plugins currently three exists.. a pure C sample that (you guessed it) really doesn't do anything productive and then a plugin version of bcdcpp's lua (this one is pretty direct port, so it is C++).

The third one is not so impressive... it adds support for various media player chat announces (spam is too negative of a word), although primarily I created it to proof that it is possible to make a plugin that modifies the GUI, even though the API itself has little to no support for such plugin (on windows anyways),

The first two plugins can be compiled with both mingw and visual studio and are also hopefully linux friendly, the third not so much.

Oh and you can mix plugins... so mingw compiled dcpp will cope just fine with visual studio compiled plugins or vice versa (obviously this also means that the stl's used can be different). In theory you should also be able to create plugins with languages such as VB and Delphi but this very much theoretical.

Well do what you want with it... it's posted now.