← Back to team overview

linuxdcpp-team team mailing list archive

[Bug 326541] Re: Request for more filtering options on search

 

very good patch overall, i have a few remarks:

- i would prefer having a vector (StringList) carried around instead of a string that has to always be broken up between its ';' chars and created again. then the function in charge of loading / saving to file will convert between the vector and a plain ';'-separated string.
it would simplify functions like SearchManager::checkExtensions which won't have to remake a new string but will just filter the vector it has been given.

- is there a reason for having search types managed by the search
manager? they seem to never interact with the search manager; they are
only a setting, so it might be more logical to put them in the settings
manager (as is done for connection types for ex).

- how is the NMDC situation handled? when selecting NMDC hubs in the search window and using custom search types, the user should be made aware that her types aren't going to get applied.
also, what happens if a user modifies one of the predefined types?
how about keeping a cached list of default search types for NMDC, so they don't have to be queried for again before every search?

-- 
Request for more filtering options on search
https://bugs.launchpad.net/bugs/326541
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.

Status in DC++: New

Bug description:
It would be a really handy feature to define own "filetype" filters.

For example we do have a file tye "archive" that would give you only zip, rar, ace and lzh-Files.
It would be really cool to add mx own types like for comics: cbr, cbz, cba, ace, zip, rar, lzh and folders.
So that I don't have to scroll trough endless lists of mp3 . . .

As far as i have been told is that an idea that would require changes in the protocol or the hub software, so I suggest an additional local filter: Search for all files on the hub, but show only . . .

Thanx for a great software!
mabuse