← Back to team overview

linuxdcpp-team team mailing list archive

Re: [Bug 600806] Re: (Open)Solaris doesn't use x64 TTH code

 

I would presume there is somethign that could be put in the SConstruct that
would say "if Sun" and "if x86-64" then "-m64". I don't know what that would
be.

At the least, something should be added to the appropriate Readme files for
future people coming along.

I've noticed that forcing -m64 appears to have broken TLS, an adcs hub
connection drops every minute or so, saying:
*** Connect failed: SSL Error: error:00000001:lib(0):func(0):reason(1) (-1,
1)
It can communicate fine for the time when it is connected.

Any thoughts on that?

On 2 July 2010 14:33, Steven Sheehy <steven.sheehy@xxxxxxxxx> wrote:

> I'm glad it works for you, but I'm not sure if including that in
> linuxdcpp would be appropriate. I imagine people using OpenSolaris with
> 32 bit CPUs wouldn't want 64 bit binaries. You can always pass custom
> flags via the CXXFLAGS and LDFLAGS environment variable instead of
> hardcoding them in SConstruct.
>
> --
> (Open)Solaris doesn't use x64 TTH code
> https://bugs.launchpad.net/bugs/600806
> You received this bug notification because you are a direct subscriber
> of the bug.
>

-- 
(Open)Solaris doesn't use x64 TTH code
https://bugs.launchpad.net/bugs/600806
You received this bug notification because you are a member of LinuxDC++
Team, which is subscribed to LinuxDC++.

Status in Linux DC++: Confirmed

Bug description:
Using rev 374, OpenSolaris b134.

TigerHash.cpp, chunk of code from line 26:

#ifdef _WIN32
#if defined(_M_X64)
#define TIGER_ARCH64
#endif
#if !(defined(_M_IX86) || defined(_M_X64))
#define TIGER_BIG_ENDIAN
#endif
#else // _WIN32
#if defined(__x86_64__) || defined(__alpha)
#define TIGER_ARCH64
#endif
#if !(defined(__i386__) || defined(__x86_64__) || defined(__alpha))
#define TIGER_BIG_ENDIAN
#endif
#endif // _WIN32

Apparently none of that matches my OSol box, and we end up using the slower 32-bit code.

If I add another line just forcing "#define TIGER_ARCH64", I get much better hashing speed. Using the normal code, I get around 58MB/s, with that define added, more like 81MB/s. Still not great, but its something.





Follow ups

References