linuxdcpp-team team mailing list archive

[klondike <franxisco1988@xxxxxxxxx>]

Review: Resubmit

Reverted all the adding locals stuff.

2) it would be useful to have an example Lua file that makes use of the new Lua bloom interface.
Added a simple script that will warn the user he may have empty files in his share (notice the use of may since BLOOM is not completely safe).

In our case I'll use it to warn the operators if somebody with unwanted files from a database appears so we ca proceed with further investigation. That other script will be on the https://code.launchpad.net/~dc4lan/adchpp-lan/trunk and I'm not adding it since I understand you don't want to merge it. 

3) removing "-Wl,--no-undefined" seems arbitrary; this can go in but i will probably try to simplify it later on. 

It's not removed, it's made conditional on a per file basis, currently the only one that removes it is the lua interface for Bloom since there is no way to link it otherwise (and even if there was, autoloading the plugin may not be a good idea).

It simply works as follow:
If you don't do anything the UNDEF environment variable will be "-Wl,--no-undefined" and thus all we be as earlier. But, if you pass UNDEF set to an empty string then the flag is gone for that environment (which is usually used for a single file).
-- 
https://code.launchpad.net/~klondike/adchpp/adchpp/+merge/150163
Your team Dcplusplus-team is subscribed to branch lp:adchpp.