← Back to team overview

linuxdcpp-team team mailing list archive

Re: [Merge] lp:~klondike/adchpp/adchpp into lp:adchpp

 

Review: Needs Fixing

1) please leave out local decl changes, as explained in <https://bugs.launchpad.net/adchpp/+bug/1131962/comments/3>.

2) it would be useful to have an example Lua file that makes use of the new Lua bloom interface.

3) removing "-Wl,--no-undefined" seems arbitrary; this can go in but i will probably try to simplify it later on. ;)
-- 
https://code.launchpad.net/~klondike/adchpp/adchpp/+merge/150163
Your team Dcplusplus-team is subscribed to branch lp:adchpp.


References