← Back to team overview

linuxdcpp-team team mailing list archive

[Bug 1132332] Re: The transition to STATE_DATA is not marked when using setDataMode

 

The patch2 was incorrect, you'll need these changes too for it to work.
Sorry for the inconvenience (fever isn't helping)

** Patch added: "Fix patch 2/2 so calls are properly made and move the method to the cpp file."
   https://bugs.launchpad.net/adchpp/+bug/1132332/+attachment/3545203/+files/aaa.patch

-- 
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to ADCH++.
https://bugs.launchpad.net/bugs/1132332

Title:
  The transition to STATE_DATA is not marked when using setDataMode

Status in ADCH++:
  New

Bug description:
  When using the setDataMode function the client won't change to the
  STATE_DATA state and thus scripts will not be noticed of the state
  change, similarly the transition back to STATE_NORMAL won't be
  notified.

  The main reason why this is not a trivial change is that a lot of our
  scripts do expect that there will only be a single transition to
  STATE_NORMAL in the whole life of the connection (see for example
  motd.lua or history.lua) so events that should be triggered once may
  get triggered various times instead.

  No patch for this yet, sorry.

To manage notifications about this bug go to:
https://bugs.launchpad.net/adchpp/+bug/1132332/+subscriptions


References