linuxdcpp-team team mailing list archive

[poy <poy@xxxxxxxxxx>]

Review: Needs Fixing

2) cool little example. i indeed don't want anything more evolved than that. please rename (bzr mv) to example_bloom.lua; possibly add comments similar to those in example.lua that explain how the bloom Lua interface gets loaded.

3) i figured that much; i was wondering why the "no-undef" had to sometimes be removed, on what seemed arbitrary to me (because not explained). can you detail "autoloading the plugin may not be a good idea"?

4) would it be possible to add an event in the bloom Lua interface that is fired when a new bloom table has been received from a client? this way, the bloom evaluation logic would happen exactly when needed rather than on state transitions. it would also remove the need for the oldstate changes which, while correct in theory, are burdensome.

5) there is a typo here:
228 +	if not conf.CheckLuaPKG('socket', 'LuaSocket 2.0.2'):  229 +		ret += dev.build('LuaFileSystem/') 230 +	if not conf.CheckLuaPKG('lfs', 'LuaFileSystem 1.5.0'): 231 +		ret += dev.build('LuaSocket/') 
-- 
https://code.launchpad.net/~klondike/adchpp/adchpp/+merge/150163
Your team Dcplusplus-team is subscribed to branch lp:adchpp.