linuxdcpp-team team mailing list archive

[poy <poy@xxxxxxxxxx>]

Review: Needs Fixing

4) look for "signal" through adchpp/ClientManager.h, adchpp/ClientManager.cpp, swig/adchpp.i then copy-paste. :)

5) the 2 dev.build calls should be switched.

6) in swig/bloom.i, i don't think getBM should return a shared_ptr. that implies that the calling script maintains a shared ownership of the bloom plugin along with the plugin manager, which doesn't make sense. the plugin manager should remain in full control of the lifetimes of the plugins it manages. so make it return BloomManager* or BloomManager& with getCurrentCore(l)->getPluginManager().getPlugin("BloomManager").get().
-- 
https://code.launchpad.net/~klondike/adchpp/adchpp/+merge/150163
Your team Dcplusplus-team is subscribed to branch lp:adchpp.