linuxdcpp-team team mailing list archive

[valdikss <1815377@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

SFV checker code contains a bug: the file name inside SFV file is
searched by substring and no check for end of line is performed.

Example:
The folder with the following files:

the.fp.2011.limited.1080p.bluray.x264-psychd.sub
the.fp.2011.limited.1080p.bluray.x264-psychd.subs.sfv

SFV file contains:

the.fp.2011.limited.1080p.bluray.x264-psychd.subs.rar 18239c0b

Expected result:
No CRC32 record for "the.fp.2011.limited.1080p.bluray.x264-psychd.sub" is found inside SFV file.

Actual result:
dcpp/SFVReader.cpp SFVReader::tryFile opens SFV file, finds "the.fp.2011.limited.1080p.bluray.x264-psychd.sub" substring and tries to convert hex string of "s.rar 18" (instead of "18239c0b") to hex value with sscanf.
the.fp.2011.limited.1080p.bluray.x264-psychd.sub is not added to share because of incorrect CRC32.

** Affects: dcplusplus
     Importance: Undecided
         Status: New


** Tags: sfv

-- 
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/1815377

Title:
  SFV checker file name bug

Status in DC++:
  New

Bug description:
  SFV checker code contains a bug: the file name inside SFV file is
  searched by substring and no check for end of line is performed.

  Example:
  The folder with the following files:

  the.fp.2011.limited.1080p.bluray.x264-psychd.sub
  the.fp.2011.limited.1080p.bluray.x264-psychd.subs.sfv

  SFV file contains:

  the.fp.2011.limited.1080p.bluray.x264-psychd.subs.rar 18239c0b

  Expected result:
  No CRC32 record for "the.fp.2011.limited.1080p.bluray.x264-psychd.sub" is found inside SFV file.

  Actual result:
  dcpp/SFVReader.cpp SFVReader::tryFile opens SFV file, finds "the.fp.2011.limited.1080p.bluray.x264-psychd.sub" substring and tries to convert hex string of "s.rar 18" (instead of "18239c0b") to hex value with sscanf.
  the.fp.2011.limited.1080p.bluray.x264-psychd.sub is not added to share because of incorrect CRC32.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dcplusplus/+bug/1815377/+subscriptions