linuxdcpp-team team mailing list archive

[eMTee <1815377@xxxxxxxxxxxxxxxxxx>]

There were numerous reports over the years of files being left out of share in situations similar to what's described here and this seems to be the most probable reason of those "randomly" skipped files in folders containing an .sfv file.
Thanks for taking care of reporting it.

** Changed in: dcplusplus
   Importance: Undecided => Medium

** Changed in: dcplusplus
       Status: New => Confirmed

-- 
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/1815377

Title:
  SFV checker file name bug

Status in DC++:
  Confirmed

Bug description:
  SFV checker code contains a bug: the file name inside SFV file is
  searched by substring and no check for end of line is performed.

  Example:
  The folder with the following files:

  the.fp.2011.limited.1080p.bluray.x264-psychd.sub
  the.fp.2011.limited.1080p.bluray.x264-psychd.subs.sfv

  SFV file contains:

  the.fp.2011.limited.1080p.bluray.x264-psychd.subs.rar 18239c0b

  Expected result:
  No CRC32 record for "the.fp.2011.limited.1080p.bluray.x264-psychd.sub" is found inside SFV file.

  Actual result:
  dcpp/SFVReader.cpp SFVReader::tryFile opens SFV file, finds "the.fp.2011.limited.1080p.bluray.x264-psychd.sub" substring and tries to convert hex string of "s.rar 18" (instead of "18239c0b") to hex value with sscanf.
  the.fp.2011.limited.1080p.bluray.x264-psychd.sub is not added to share because of incorrect CRC32.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dcplusplus/+bug/1815377/+subscriptions