← Back to team overview

linuxdcpp-team team mailing list archive

[Bug 1682791] Re: Unencrypted CCPM connections are not being rejected

 

IIRC CryptoManager::TLSOk() was set to return always false during the tests. Also in the then latest version of DC++ it was impossible to initiate CCPM unless you were connected to an ADCS hub - that block had to be removed as well for the test.
The ADCS hub requirement has since been removed so starting an unencryped connection to a client that has CCPM in the supports flags may be possible in DC++ 0.870 (not tested).
The committed fix is based on what AirDC++ does, it should block unencrypted attempts in both directions.

** Changed in: dcplusplus
       Status: Triaged => Fix Committed

-- 
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/1682791

Title:
  Unencrypted CCPM connections are not being rejected

Status in AirDC++:
  Fix Released
Status in DC++:
  Fix Committed

Bug description:
  The application still incorrectly shows that direct encrypted channel
  has been established. AirDC++ also shouldn't allow establishing direct
  encrypted channels when transfer encryption has been disabled.

To manage notifications about this bug go to:
https://bugs.launchpad.net/airdcpp/+bug/1682791/+subscriptions



References