linuxdcpp-team team mailing list archive

[eMTee <1309390@xxxxxxxxxxxxxxxxxx>]

** Information type changed from Private Security to Public

-- 
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/1309390

Title:
  crash if seeker.size() < 4

Status in DC++:
  Fix Released

Bug description:
  FlylinkDC++ r5xx ~230 crash if seeker.size() < 4

  http://yadi.sk/d/WtdtH7BGMhYsP -  seeker = ":0" !

  Crash dump:
  https://crash-server.com/Problem.aspx?ClientID=ppa&ProblemID=64297
  https://crash-server.com/Problem.aspx?ClientID=ppa&ProblemID=63507

  
  hot fix for original DC++:

  diff -r f0b0e8d11291 dcpp/NmdcHub.cpp
  --- a/dcpp/NmdcHub.cpp  Thu Apr 17 12:46:07 2014 +0300
  +++ b/dcpp/NmdcHub.cpp  Fri Apr 18 12:03:48 2014 +0400
  @@ -262,7 +262,8 @@
                          }
                  } else {
                          // Hub:seeker
  -                       if(Util::stricmp(seeker.c_str() + 4, getMyNick().c_str()) == 0) {
  +                       if(seeker.size() > 4 &&
  +                                Util::stricmp(seeker.c_str() + 4, getMyNick().c_str()) == 0) {
                                  return;
                          }
                  }

To manage notifications about this bug go to:
https://bugs.launchpad.net/dcplusplus/+bug/1309390/+subscriptions