lubuntu-desktop team mailing list archive

[PCMan <pcman.tw@xxxxxxxxx>]

No, your script didn't do the right thing.
If gnome-screensaver is not running, gnome-screen-saver-command
shouldn't be called.
If you do this, gnome-screen-saver will be launched, but nothing will happen.
At the same time it's possible that the user is actually running xscreensaver.

If the user is running xscreensaver, and you call
gnome-screensaver-command, this will result in gnome-screensaver being
launched and xscreensaver being bypassed, which is just the wrong
behavior.

Checking if the screensaver is currently running is necessary.
Relying on failure of their *-command programs is not a reliable solution.
That's why your script is not used directly.

On Tue, Sep 14, 2010 at 3:04 AM, Guido Berhoerster
<guido+sourceforge.net@xxxxxxxxxxxxxxxx> wrote:
> * PCMan <pcman.tw@xxxxxxxxx> [2010-09-13 19:38]:
>> The features mentitioned in this mail is implemanted in "lock" branch now.
>> Please test if it works as expected.
>> If there are no obvious problems and objections, I'd like to merge it
>> to master branch to be included in the latest release of lxsession.
>>
>> http://lxde.git.sourceforge.net/git/gitweb.cgi?p=lxde/lxsession;a=shortlog;h=refs/heads/lock
>
> Please use the script I sent you, it does exactly the same as
> yours in 8 instead of 23 lines and it is actually portable.
>
> --
> Guido Berhoerster
>