← Back to team overview

mactel-support team mailing list archive

LCD panel brightness control for MacBookPro6,2

 

Please apply the attached patches for mbp-nvidia-bl-dkms and pommed -> LCD panel brightness control works flawlessly for me (also keyboard brightness control does).

btw: I hope I included the right package maintained (bitmath.org) for the mbp-nvidia-bl-dkms package, if not: sorry

-bf
diff -Nur pommed-1.31~dfsg/pommed/kbd_backlight.h pommed-1.31~dfsgpatched/pommed/kbd_backlight.h
--- pommed-1.31~dfsg/pommed/kbd_backlight.h	2010-01-10 11:06:45.000000000 +0100
+++ pommed-1.31~dfsgpatched/pommed/kbd_backlight.h	2010-05-04 23:45:55.105648406 +0200
@@ -68,6 +68,7 @@
 	  || (mops->type == MACHINE_MACBOOKPRO_3)
 	  || (mops->type == MACHINE_MACBOOKPRO_4)
 	  || (mops->type == MACHINE_MACBOOKPRO_5)
+	  || (mops->type == MACHINE_MACBOOKPRO_6)
 	  || (mops->type == MACHINE_MACBOOK_5)
 	  || (mops->type == MACHINE_MACBOOKAIR_1)
 	  || (mops->type == MACHINE_MACBOOKAIR_2));
diff -Nur pommed-1.31~dfsg/pommed/pommed.c pommed-1.31~dfsgpatched/pommed/pommed.c
--- pommed-1.31~dfsg/pommed/pommed.c	2010-01-10 11:06:45.000000000 +0100
+++ pommed-1.31~dfsgpatched/pommed/pommed.c	2010-05-04 23:33:34.405645927 +0200
@@ -287,6 +287,14 @@
     /* .evdev_identify = evdev_is_wellspring3, */
   },
 
+  {  /* MacBookPro6,2 (15", Core i7, April 2010 */
+    .type = MACHINE_MACBOOKPRO_6,
+    .lcd_backlight_probe = mbp_sysfs_backlight_probe,
+    .lcd_backlight_step = sysfs_backlight_step,
+    .lcd_backlight_toggle = sysfs_backlight_toggle,
+    /* .evdev_identify = evdev_is_wellspring3, */
+  },
+
   /* MacBook machines */
 
   {  /* MacBook1,1 (Core Duo) */
@@ -683,6 +691,8 @@
 	   || (strcmp(buf, "MacBookPro5,4") == 0)
 	   || (strcmp(buf, "MacBookPro5,5") == 0))
     ret = MACHINE_MACBOOKPRO_5;
+  else if (strcmp(buf, "MacBookPro6,2") == 0)
+    ret = MACHINE_MACBOOKPRO_6;
   /* Core Duo MacBook (May 2006) */
   else if (strcmp(buf, "MacBook1,1") == 0)
     ret = MACHINE_MACBOOK_1;
diff -Nur pommed-1.31~dfsg/pommed/pommed.h pommed-1.31~dfsgpatched/pommed/pommed.h
--- pommed-1.31~dfsg/pommed/pommed.h	2010-01-10 11:06:45.000000000 +0100
+++ pommed-1.31~dfsgpatched/pommed/pommed.h	2010-05-04 23:33:49.566273028 +0200
@@ -35,6 +35,7 @@
     MACHINE_MACBOOKPRO_3,
     MACHINE_MACBOOKPRO_4,
     MACHINE_MACBOOKPRO_5,
+    MACHINE_MACBOOKPRO_6,
 
     MACHINE_MACBOOK_1,
     MACHINE_MACBOOK_2,
--- mbp-nvidia-bl-dkms-0.24.2/usr/src/dkms_source_tree/mbp_nvidia_bl.c	2010-03-31 20:06:09.000000000 +0200
+++ mbp-nvidia-bl-dkms-0.24.2patched/usr/src/dkms_source_tree/mbp_nvidia_bl.c	2010-05-04 23:23:43.076271347 +0200
@@ -382,6 +382,15 @@
 		},
 		.driver_data	= (void *)&nvidia_chipset_data,
 	},
+	{
+		.callback	= mbp_dmi_match,
+		.ident		= "MacBookPro 6,2",
+		.matches	= {
+			DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro6,2"),
+		},
+		.driver_data	= (void *)&intel_chipset_data,
+	},
 	{ }
 };
 

Follow ups