magentoerpconnect-community team mailing list archive

[Raphaël Valyi <rvalyi@xxxxxxxxx>]

Hello Jordi,

We thank you very much for all your contributions but I should say I don't
feel very comfortable with one of your commit:
http://bazaar.launchpad.net/~openlabs-akretion-consortium/magentoerpconnect/magentoerpconnect_generic/revision/288

So you add a dependency upon "account_payment" and seems to use it a bit
like we currently use statement for customers payments (I'm not sure I get
it all, but it seems that this is the big picture).

The reason why I'm not sure this is good is:
- we already deal with customers payments by making a statement on the
proper journal thanks to the sale_order#generate_payment_with_pay_code
method brought by the base_sale_multichannels module.
It might not be very sophisticated but it looks it cover everything Magento
do in relation with payments (or do I miss something?)
- we do not depend on any other module, so it's kind of minimalist
- but mostly, looking at the account_payment documentation, it looks like
this module is mostly aimed at managing your suppliers payments and not your
customers payments. Indeed, from the doc:
http://doc.openerp.com/book/3/3_7/accounting_entries.html?highlight=account_payment

"The system lets you enter a series of payments to be carried out from your
various bank accounts. Once the different payments have been registered you
can validate the payment orders. During validation you can modify and
approve the payment orders, sending the order to the bank for electronic
funds transfer or just printing cheques as you wish.

For example if you have to pay a supplier’s invoice for a large amount you
can split the payments amongst several bank accounts according to their
available balance. To do this you can prepare several Draft orders and
validate them once you’re satisfied that the split is correct."

So I wonder: why are the exact reasons why you bring the whole
"account_payment" module here?

BTW, just in case, here is the process we do to deal with payments: we often
use intermediary accounts to receive customers payments, so the statements
(generated according to Magento payment method codes) will then send money
to those intermediary accounts when validated. On the other side of the
pipe, we receive the bank files, in our case we use TermniatOOOR
http://github.com/rvalyi/terminatooor (but everybody odes as we wants,
nothing mandatory) to create the bank statements, we then use the automatic
OpenERP mass reconciliation system to reconcile most of those payments
statements and bank statements automatically. I don't see what kind of
benefit account_payment would bring here, but may be it's just that I miss
something.


So, would you please explain us why you introduced the account_payment
dependency, has it some big advantage over the existing method I described ?
If not, I suggest to package it as an independent optional module. What do
you all think about that?

PS: we are pushing a bunch of multi's fixes as you can see with the
Sebastien's branch here
https://code.launchpad.net/~akretion-team/magentoerpconnect/Multi-website-fixand
there is more to come, I'll propose some base_external_referentials
refactoring here later on.


Best regards, and thanks a lot for contributing,


Raphaël Valyi

http://www.akretion.com