mahara-contributors team mailing list archive

[Richard Mansfield <702264@xxxxxxxxxxxxxxxxxx>]

If the intention is to allow site admins to 'drop in' more antispam
files and be able to order them as they like, then the default weights
should leave gaps: maybe number them as 10, 20, 30 rather than 00, 01,
02.  I don't think it's very likely that anyone would make use of this
though, so it doesn't seem like a big advantage over just hardcoding the
ordering somewhere in antispam.php.

If we really need to be able to drop in files with weights, then
defining the weight inside each file seems better than filename
ordering, but I don't care that much about it, and putting the weights
in the files would mean the available_spam_traps function would have to
be a bit more complicated and read the files in.


In the long run these existing spam classes could be rewritten a bit and given more descriptive names anyway.  All the stuff in Simple to do with checking email addresses are well-formed, and checking that name and subject fields don't contain newlines could be moved into pieform rules that people could use to validate any field in any form.  If we did that, there wouldn't be much left in Simple apart from counting URLs in body fields, and then it would make sense to change the names from Simple to 'Count URLs' and Advanced to 'Check blacklisted URLs' or something like that.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/702264

Title:
  Item order in Site Settings -> Security Settings -> Anti-spam

Status in Mahara ePortfolio:
  In Progress

Bug description:
  Items are now ordered in alphabetical order, e.g. Advanced, None,
  Simple. Maybe it would be better to display them in ascending-measures
  order, e.g. None, Simple, Advanced