← Back to team overview

mahara-contributors team mailing list archive

[Bug 891170] [NEW] race conditions in cron

 

Public bug reported:

Thanks to tim hunt at the OU for pointing the first issue out:

It's possible for cron_lock to fail to get the $started value if the row has been deleted between attempting to insert the record, and attempting to retrieve the start date
http://gitorious.org/mahara/mahara/blobs/master/htdocs/lib/cron.php#line488

Additionally, when we try to restart a job which has been running for > 24 hours, we should probably call cron_lock() rather than insert_record()
http://gitorious.org/mahara/mahara/blobs/master/htdocs/lib/cron.php#line498

That said, we're very unlikely to ever hit this given the use of cron.

** Affects: mahara
     Importance: Low
         Status: New


** Tags: cron

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/891170

Title:
  race conditions in cron

Status in Mahara ePortfolio:
  New

Bug description:
  Thanks to tim hunt at the OU for pointing the first issue out:

  It's possible for cron_lock to fail to get the $started value if the row has been deleted between attempting to insert the record, and attempting to retrieve the start date
  http://gitorious.org/mahara/mahara/blobs/master/htdocs/lib/cron.php#line488

  Additionally, when we try to restart a job which has been running for > 24 hours, we should probably call cron_lock() rather than insert_record()
  http://gitorious.org/mahara/mahara/blobs/master/htdocs/lib/cron.php#line498

  That said, we're very unlikely to ever hit this given the use of cron.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/891170/+subscriptions


Follow ups

References