mahara-contributors team mailing list archive

[François Marier <francois@xxxxxxxxxx>]

I would be a little bit cautious about this because that's exactly the
kind of thing we will forget about and then we could end up generating
tarballs that are missing files. The way we currently test releases (we
don't test the tarball, we test the git tag for it) there is a very real
danger of releasing things that don't work.

A warning in the push alias that gets printed every time we push is,
usability-wise, equivalent to no warning at all. Our eyes will quickly
get used to it and will happily filter it out for us. So I don't think
that's going to help much.

I think that if we're going to have tests all over the place (as opposed
to self-contained in a separate directory like the selenium tests), then
we should add these full paths to the .gitattributes file. Sure, if we
miss one, it ends up in the release, but that's not a big problem
compared to not shipping a file that is really needed.

** Changed in: mahara
       Status: New => Triaged

** Changed in: mahara
       Status: Triaged => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/897593

Title:
  Update .gitattributes to excluded tests from built releases

Status in Mahara ePortfolio:
  In Progress

Bug description:
  When generating releases, we currently do not include our tests (e.g.
  selenium).

  It's been proposed that we allow for unit tests to be located within
  each component (e.g. /blocks/XXX/tests/) to allow for easier
  maintenance of that module.

  The files are excluded from release tarballs using a .gitattributes
  file.

  The change I'm submitting is a little heavy-handed and will prohibit
  the use of a directory or file named tests anywhere within mahara. If
  accepted, we should add a warning on push (e.g. in the Makefile) to
  remind that this directory is always excluded.

  An alternative would be to modify the release script to find all
  occurrences of tests/phpunit and place these into a new .gitattributes
  file, and then to use the --worktree-attributes option to git archive
  to ensure that specific candidates are removed. If this option is
  preferred, we should also attempt to remove empty tests directories.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/897593/+subscriptions