← Back to team overview

mahara-contributors team mailing list archive

[Bug 897593] [NEW] Update .gitattributes to excluded tests from built releases

 

Public bug reported:

When generating releases, we currently do not include our tests (e.g.
selenium).

It's been proposed that we allow for unit tests to be located within
each component (e.g. /blocks/XXX/tests/) to allow for easier maintenance
of that module.

The files are excluded from release tarballs using a .gitattributes
file.

The change I'm submitting is a little heavy-handed and will prohibit the
use of a directory or file named tests anywhere within mahara. If
accepted, we should add a warning on push (e.g. in the Makefile) to
remind that this directory is always excluded.

An alternative would be to modify the release script to find all
occurrences of tests/phpunit and place these into a new .gitattributes
file, and then to use the --worktree-attributes option to git archive to
ensure that specific candidates are removed. If this option is
preferred, we should also attempt to remove empty tests directories.

** Affects: mahara
     Importance: Low
     Assignee: Andrew Nicols (dobedobedoh)
         Status: New


** Tags: release tests

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/897593

Title:
  Update .gitattributes to excluded tests from built releases

Status in Mahara ePortfolio:
  New

Bug description:
  When generating releases, we currently do not include our tests (e.g.
  selenium).

  It's been proposed that we allow for unit tests to be located within
  each component (e.g. /blocks/XXX/tests/) to allow for easier
  maintenance of that module.

  The files are excluded from release tarballs using a .gitattributes
  file.

  The change I'm submitting is a little heavy-handed and will prohibit
  the use of a directory or file named tests anywhere within mahara. If
  accepted, we should add a warning on push (e.g. in the Makefile) to
  remind that this directory is always excluded.

  An alternative would be to modify the release script to find all
  occurrences of tests/phpunit and place these into a new .gitattributes
  file, and then to use the --worktree-attributes option to git archive
  to ensure that specific candidates are removed. If this option is
  preferred, we should also attempt to remove empty tests directories.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/897593/+subscriptions


Follow ups

References