mahara-contributors team mailing list archive

[Mahara Bot <933937@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/1056
Committed: http://gitorious.org/mahara/mahara/commit/11bcc0d0c6c7bda18c6cd2a2d669f5dfe4fc5208
Submitter: Francois Marier (francois@xxxxxxxxxxxxxxx)
Branch:    master

commit 11bcc0d0c6c7bda18c6cd2a2d669f5dfe4fc5208
Author: Richard Mansfield <richard.mansfield@xxxxxxxxxxxxxxx>
Date:   Fri Feb 17 15:06:34 2012 +1300

    Fix method names in auth plugin and instance configuration (bug #933937)
    
    The validation/submission methods called during auth *plugin*
    configuration and auth *instance* configuration have the same names,
    but in each of these cases, the methods deal with completely different
    data, and are passed arguments in a different order.
    
    This is a problem for the saml plugin, which needs to detect where
    it's being called from, and reverse the order of the arguments if
    necessary.
    
    To fix this, the new methods validate_instance_config_options and
    save_instance_config_options are called during instance configuration,
    and the names 'validate_config_options' and 'save_config_options' are
    left for global plugin configuration, as these are the names used for
    all other plugin types.
    
    The old names are still usable in case any third party auth plugins
    are relying on them, but they'll produce a warning when called during
    instance configuration.
    
    Change-Id: I996ed7a2cdbe0e50dcb0c88560d10a2044b4e21c
    Signed-off-by: Richard Mansfield <richard.mansfield@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/933937

Title:
  Conflicting method names in auth plugin and instance configuration

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  The methods called for validation and submission during auth plugin
  configuration and auth instance configuration have the same names, but
  these methods deal with completely different fields, and are passed
  arguments in a different order.

  In core, this is only a problem for the saml plugin (the only auth
  plugin to have global configuration), but we should give these methods
  different names so that the saml plugin doesn't have to swap arguments
  around, and to avoid confusion for other plugin developers.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/933937/+subscriptions