mahara-contributors team mailing list archive
-
mahara-contributors team
-
Mailing list archive
-
Message #10979
[Bug 1072972] Re: Internal search ignores 'KATAKANA-HIRAGANA PROLONGED SOUND MARK'
Hi Takahiro,
Doesn't appear in drupal 7, but in drupal 6 the relevant commit is
48abe7ae3913f77d9faee199b61ee3ff61c5cbcf
There is also the following commit that changes this definition
744575c8cb5c2ecb33b8dab9239396b6fcde0d2b
The remote I'm using is http://git.drupal.org/project/drupal.git
If you would like, you can submit a patch for this to our review system.
See this page to see how to get set up.
https://wiki.mahara.org/index.php/Developer_Area/Contributing_Code#Submitting_commits_for_review
Thanks for reporting this :D
Cheers,
Hugh
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/1072972
Title:
Internal search ignores 'KATAKANA-HIRAGANA PROLONGED SOUND MARK'
Status in Mahara ePortfolio:
Triaged
Bug description:
Mahara's (1.5.6) internal search cannot handle Japanese character
'KATAKANA-HIRAGANA PROLONGED SOUND MARK'. This character 'ー' is
frequently used. For example 'データ (data)', 'サーバー (server)' or
'ポートフォリオ (portfolio)'.
The cause of problem is line 1102 in search/internal/lib.php.
1102: $text = preg_replace('/['. PREG_CLASS_SEARCH_EXCLUDE .
']+/u', ' ', $text);
In this line, mahara replaces special characters specified by
PREG_CLASS_SEARCH_EXCLUDE with ' '. And 'KATAKANA-HIRAGANA PROLONGED
SOUND MARK' is included in PREG_CLASS_SEARCH_EXCLUDE.
The solution of this problem is very simple. Just remove 'KATAKANA-
HIRAGANA PROLONGED SOUND MARK' (code 0x30fc) from
PREG_CLASS_SEARCH_EXCLUDE. We can find the definition on line
1198-1225.
1221:
'\x{3099}-\x{309e}\x{30a0}\x{30fb}-\x{30fe}\x{3190}-\x{319f}\x{31c0}-\x{31cf}'.
should be replaced with
1221:
'\x{3099}-\x{309e}\x{30a0}\x{30fb}\x{30fd}\x{30fe}\x{3190}-\x{319f}\x{31c0}-\x{31cf}'.
P.S. The definition of PREG_CLASS_SEARCH_EXCLUDE is originally from
Drupal, and this fix was already applied.
http://api.drupal.org/api/drupal/modules!search!search.module/constant/PREG_CLASS_SEARCH_EXCLUDE/6
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1072972/+subscriptions
References