mahara-contributors team mailing list archive

[Aaron Wells <1191497@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

While working on page/collection access control, I noticed that there
are currently extraneous view_access.approvecomments and
view_access.allowcomments columns.

These are currently extraneous, because there are also
view.approvecomments and view.allowcomments columns. And there's only
one checkbox on the Access settinngs page, which pops the same value
into the columns in VIEW and into all the records in VIEW_ACCESS.

The funny thing is, though, that these values in VIEW_ACCESS are checked
by a function, when the code is determining whether or not a user should
see the comment form. So in theory, all we need to do to activate this
feature is add checkboxes to the access control lists. At first, I
thought we should just remove the extraneous columns, but it actually
could be useful to say, "I want to allow my friends to comment without
moderation; I want to not allow the public to comment at all."

** Affects: mahara
     Importance: Wishlist
         Status: Triaged


** Tags: comments

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contrib members
https://bugs.launchpad.net/bugs/1191497

Title:
  Micromanage allow/approve comments

Status in Mahara ePortfolio:
  Triaged

Bug description:
  While working on page/collection access control, I noticed that there
  are currently extraneous view_access.approvecomments and
  view_access.allowcomments columns.

  These are currently extraneous, because there are also
  view.approvecomments and view.allowcomments columns. And there's only
  one checkbox on the Access settinngs page, which pops the same value
  into the columns in VIEW and into all the records in VIEW_ACCESS.

  The funny thing is, though, that these values in VIEW_ACCESS are
  checked by a function, when the code is determining whether or not a
  user should see the comment form. So in theory, all we need to do to
  activate this feature is add checkboxes to the access control lists.
  At first, I thought we should just remove the extraneous columns, but
  it actually could be useful to say, "I want to allow my friends to
  comment without moderation; I want to not allow the public to comment
  at all."

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1191497/+subscriptions