mahara-contributors team mailing list archive

[Aaron Wells <1215702@xxxxxxxxxxxxxxxxxx>]

Already merged into master, don't know why I didn't bother creating a
bug for it: https://reviews.mahara.org/#/c/2388/

** Also affects: mahara/1.5
   Importance: Undecided
       Status: New

** Also affects: mahara/1.6
   Importance: Undecided
       Status: New

** Also affects: mahara/1.7
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contrib members
https://bugs.launchpad.net/bugs/1215702

Title:
  Reduce false positives in syntax checker for unbracketed SQL tables

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.5 series:
  New
Status in Mahara 1.6 series:
  New
Status in Mahara 1.7 series:
  New

Bug description:
  The check for SQL tables that aren't surrounded by {}, which was added
  to test/coding-standard-check.pl, also matches comments that contain
  these very common words, and that results in a lot of false positives
  from the script, which mkaes people less likely to pay attention to
  its output.

  We should reduce the false positives by changing the regular
  expression so that it ignores the words "from" and "join" when they
  occur in comments.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1215702/+subscriptions