mahara-contributors team mailing list archive

[Aaron Wells <1215702@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

The check for SQL tables that aren't surrounded by {}, which was added
to test/coding-standard-check.pl, also matches comments that contain
these very common words, and that results in a lot of false positives
from the script, which mkaes people less likely to pay attention to its
output.

We should reduce the false positives by changing the regular expression
so that it ignores the words "from" and "join" when they occur in
comments.

** Affects: mahara
     Importance: Medium
     Assignee: Aaron Wells (u-aaronw)
         Status: Fix Committed

** Affects: mahara/1.5
     Importance: Undecided
         Status: New

** Affects: mahara/1.6
     Importance: Undecided
         Status: New

** Affects: mahara/1.7
     Importance: Undecided
         Status: New


** Tags: tests

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contrib members
https://bugs.launchpad.net/bugs/1215702

Title:
  Reduce false positives in syntax checker for unbracketed SQL tables

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.5 series:
  New
Status in Mahara 1.6 series:
  New
Status in Mahara 1.7 series:
  New

Bug description:
  The check for SQL tables that aren't surrounded by {}, which was added
  to test/coding-standard-check.pl, also matches comments that contain
  these very common words, and that results in a lot of false positives
  from the script, which mkaes people less likely to pay attention to
  its output.

  We should reduce the false positives by changing the regular
  expression so that it ignores the words "from" and "join" when they
  occur in comments.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1215702/+subscriptions