mahara-contributors team mailing list archive

[Mahara Bot <1215702@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/2433
Committed: http://gitorious.org/mahara/mahara/commit/d6f0092f337ef4eb094b63de1bffb3b2f5b636ba
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    1.6_STABLE

commit d6f0092f337ef4eb094b63de1bffb3b2f5b636ba
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Mon Aug 5 13:40:44 2013 +1200

Reduce false positives in syntax checket for unbracketed SQL tables.

Bug #1215702
This one gets me a lot of false positives, so I'm changing the message to explain
that it's triggered by the words "from" and "join", and make it so that it doesn't
perform this check on lines that are probably comments

Change-Id: I5d1acc5eed0a31acc0a570b9bdac564ca514707f

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contrib members
https://bugs.launchpad.net/bugs/1215702

Title:
  Reduce false positives in syntax checker for unbracketed SQL tables

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.5 series:
  Fix Committed
Status in Mahara 1.6 series:
  Fix Committed
Status in Mahara 1.7 series:
  Fix Committed

Bug description:
  The check for SQL tables that aren't surrounded by {}, which was added
  to test/coding-standard-check.pl, also matches comments that contain
  these very common words, and that results in a lot of false positives
  from the script, which mkaes people less likely to pay attention to
  its output.

  We should reduce the false positives by changing the regular
  expression so that it ignores the words "from" and "join" when they
  occur in comments.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1215702/+subscriptions