mahara-contributors team mailing list archive

[Aaron Wells <1208287@xxxxxxxxxxxxxxxxxx>]

** Also affects: mahara/1.6
   Importance: Undecided
       Status: New

** Also affects: mahara/1.7
   Importance: Undecided
       Status: New

** Changed in: mahara/1.6
    Milestone: None => 1.6.8

** Changed in: mahara/1.7
    Milestone: None => 1.7.4

** Changed in: mahara/1.6
   Importance: Undecided => Low

** Changed in: mahara/1.7
   Importance: Undecided => Low

** Changed in: mahara
       Status: In Progress => Fix Committed

** Changed in: mahara/1.6
       Status: New => Confirmed

** Changed in: mahara/1.7
       Status: New => Confirmed

** Changed in: mahara/1.6
     Assignee: (unassigned) => Aaron Wells (u-aaronw)

** Changed in: mahara/1.7
     Assignee: (unassigned) => Aaron Wells (u-aaronw)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1208287

Title:
  Clarify error message in Mahara syntax checker about table names with
  {}

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.6 series:
  Confirmed
Status in Mahara 1.7 series:
  Confirmed

Bug description:
  I keep getting false positives from this syntax check:

          if (/\b(from|join)\s[^({]/i) {
              bad_line("this sql table is not surrounded by curly braces {}, ".
                       "or is not an anonymous inner select", $_);
          }

  That's because it kicks in if you have comments including the very
  common preposition "from", or less frequently the word "join". I'm
  going to change the text in the Makefile to clarify what's triggering
  the message.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1208287/+subscriptions