mahara-contributors team mailing list archive

[Aaron Wells <1208287@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

I keep getting false positives from this syntax check:

        if (/\b(from|join)\s[^({]/i) {
            bad_line("this sql table is not surrounded by curly braces {}, ".
                     "or is not an anonymous inner select", $_);
        }

That's because it kicks in if you have comments including the very
common preposition "from", or less frequently the word "join". I'm going
to change the text in the Makefile to clarify what's triggering the
message.

** Affects: mahara
     Importance: Low
     Assignee: Aaron Wells (u-aaronw)
         Status: In Progress


** Tags: gerrit

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contrib members
https://bugs.launchpad.net/bugs/1208287

Title:
  Clarify error message in Mahara syntax checker about table names with
  {}

Status in Mahara ePortfolio:
  In Progress

Bug description:
  I keep getting false positives from this syntax check:

          if (/\b(from|join)\s[^({]/i) {
              bad_line("this sql table is not surrounded by curly braces {}, ".
                       "or is not an anonymous inner select", $_);
          }

  That's because it kicks in if you have comments including the very
  common preposition "from", or less frequently the word "join". I'm
  going to change the text in the Makefile to clarify what's triggering
  the message.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1208287/+subscriptions