mahara-contributors team mailing list archive

[Mahara Bot <1268788@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/2944
Committed: http://gitorious.org/mahara/mahara/commit/1a5d395cdb87a7e2ae14f251a562315f5ace87c6
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 1a5d395cdb87a7e2ae14f251a562315f5ace87c6
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Tue Jan 21 14:39:42 2014 +1300

Revert "Add class JavascriptDetector for checking if javascript is
enabled"

This reverts commit 1cdc0486e956fbc4e2e1a10f50818156aece16ce.

The JSDetector class has caused three regressions so far (Bug 1270846,
Bug 1261610, and Bug 1268788). Since it's been buggy and it's not
actively in use anywhere in the site, I think we should revert it.

Change-Id: If32d5adf8733ce3f455aab09a5d138c7707ae95d

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1268788

Title:
  mobile_api_json_reply sends extra stuff at the top, making it invalid
  json

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  An example is this, using the wrong api token

  D/RestClient( 2917): Response =     <form name="jsdetector_form" id="jsdetector_form" method="post">
  D/RestClient( 2917):         <input name="javascriptenabled" type="hidden" value="true" />
  D/RestClient( 2917):         <script type="text/javascript">
  D/RestClient( 2917):             document.jsdetector_form.submit();
  D/RestClient( 2917):         </script>
  D/RestClient( 2917):     </form>{"fail":"Sorry that mobile upload token was not found. Please check your site and mobile application settings."}

  Stolen from a maharadroid with a patch to log the responses, but that
  can be obtained with easier ways.

  Just need to find the jsdectector stuff and make sure it isn't done in
  a part of mahara that has json reply in it. This may actually break
  some of the json stuff as well? or the /api/mobile/sync.php needs a
  define of JSON at the top.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1268788/+subscriptions