mahara-contributors team mailing list archive

[Mahara Bot <1261610@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/2944
Committed: http://gitorious.org/mahara/mahara/commit/1a5d395cdb87a7e2ae14f251a562315f5ace87c6
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 1a5d395cdb87a7e2ae14f251a562315f5ace87c6
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Tue Jan 21 14:39:42 2014 +1300

Revert "Add class JavascriptDetector for checking if javascript is
enabled"

This reverts commit 1cdc0486e956fbc4e2e1a10f50818156aece16ce.

The JSDetector class has caused three regressions so far (Bug 1270846,
Bug 1261610, and Bug 1268788). Since it's been buggy and it's not
actively in use anywhere in the site, I think we should revert it.

Change-Id: If32d5adf8733ce3f455aab09a5d138c7707ae95d

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1261610

Title:
  JSDetector adds output to command-line scripts

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  In Mahara 1.9dev, every time I run the command-line installer, I see
  this at the start of the output:

      <form name="jsdetector_form" id="jsdetector_form" method="post">
          <input name="javascriptenabled" type="hidden" value="true" />
          <script type="text/javascript">
              document.jsdetector_form.submit();
          </script>
      </form>[INF] d4 (admin/cli/install.php:68) Installing Mahara

  I suspect this is from the JSDetector class that we added. We should
  disable that, because it's not needed when you're running at the
  command-line.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1261610/+subscriptions