← Back to team overview

mahara-contributors team mailing list archive

[Bug 1288490] A change has been merged

 

Reviewed:  https://reviews.mahara.org/3080
Committed: http://gitorious.org/mahara/mahara/commit/4da1f28a30425771103be0d2c557931104461704
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 4da1f28a30425771103be0d2c557931104461704
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Mar 6 13:32:56 2014 +1300

Failure on upgrade from 1.8 to 1.9 (Bug #1288490)

Don't run the usr_custom_layout upgrade patch if it was run before.
We check for the presence of the usr_custom_layout.group column to
see whether the patch has been run (or the instance was installed
with the fixes already in place).

Change-Id: I3adfd13ef622edc0c18de630869bd2a46700bbfb
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1288490

Title:
  upgrade from 1.8 error

Status in Mahara ePortfolio:
  Confirmed

Bug description:
  when I upgrade from 1.8_STABLE to 1.9dev I get this error:

   Could not execute command: ALTER TABLE usr_custom_layout ADD CONSTRAINT usrcustlayo_gro_fk FOREIGN KEY (`group`) REFERENCES `group` (id)
  Call stack (most recent first):

      execute_sql("ALTER TABLE usr_custom_layout ADD CONSTRAINT usrcu...") at /home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/dml.php:1388
      execute_sql_arr(array(size 1), true, true) at /home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/ddl.php:1210
      add_key(object(XMLDBTable), object(XMLDBKey)) at /home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/db/upgrade.php:2937
      xmldb_core_upgrade("2013101408") at /home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/upgrade.php:295
      upgrade_core(object(stdClass)) at /home/robertl/htdocs/mahara-devel/mahara/htdocs/admin/upgrade.json.php:78

  This is because a fix 09b2f5ba730d4d03950c713c1baaf1cb3174cde2 was
  added to master and also backported to 1.8

  The version in master needs to check if foreign keys already exist or
  not.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1288490/+subscriptions


References