mahara-contributors team mailing list archive

[Aaron Wells <1301096@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

In htdocs/lib/file.php, right above file_mime_type(), there's another
method called get_mime_type() that uses the Unix "file" utility. It's
only used one place in the code, which is in an upgrade to the file
artefact type from 2008.

I'd like to eliminate this redundant function to prevent other people
from accidentally using it. Since the function is only used one place,
we can make the upgrade script continue to work by just copying the
whole text of the function inline into the upgrade.php

** Affects: mahara
     Importance: Low
     Assignee: Aaron Wells (u-aaronw)
         Status: In Progress

** Changed in: mahara
   Importance: Undecided => Low

** Changed in: mahara
     Assignee: (unassigned) => Aaron Wells (u-aaronw)

** Changed in: mahara
    Milestone: None => 1.9.0

** Changed in: mahara
       Status: New => In Progress

** Summary changed:

- Eliminate redundant &obsolete get_mime_type() file
+ Eliminate redundant &obsolete get_mime_type() function

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1301096

Title:
  Eliminate redundant &obsolete get_mime_type() function

Status in Mahara ePortfolio:
  In Progress

Bug description:
  In htdocs/lib/file.php, right above file_mime_type(), there's another
  method called get_mime_type() that uses the Unix "file" utility. It's
  only used one place in the code, which is in an upgrade to the file
  artefact type from 2008.

  I'd like to eliminate this redundant function to prevent other people
  from accidentally using it. Since the function is only used one place,
  we can make the upgrade script continue to work by just copying the
  whole text of the function inline into the upgrade.php

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1301096/+subscriptions