mahara-contributors team mailing list archive

[Mahara Bot <1310861@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3271
Committed: http://gitorious.org/mahara/mahara/commit/ee77e0365c1991aaa236ef5d5abb554e3e36fe1b
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit ee77e0365c1991aaa236ef5d5abb554e3e36fe1b
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Apr 23 08:13:27 2014 +1200

Only Admins can comment on objectionable pages when comments turned off

Bug 1310861

Currently if someone marks a page, that has comments set to off,
objectionable then eveyone that can access the page can now leave
comments.

Have adjusted it so that only admins can leave comments.

Change-Id: I82bd01814e73c39b056082965a6b483e6346a82f
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1310861

Title:
  marking page objectionable now allows feedback

Status in Mahara ePortfolio:
  In Progress

Bug description:
  If user A:
  - creates a page
  - turns off feedback/comments
  - shares it with logged in users

  And User B comes along and marks it as objectionable

  The ability to leave comments is activated and so now user C, D, and E
  can all leave comments.

  This is all due to the view_access table getting updated with
  'allowcomments' column set to a hardcoded 1 rather than respecting the
  settings of the view.

  I could imagine that an Admin user, who has the permissions to update
  a page as 'not objectionable' may also want the ability to leave a
  comment as well.

  But I believe for all other users they should not be allowed to leave
  a comment.

  So we either need to respect the allow comment setting for the page when saving the view_access 'objectionable' row,
   or get it so that if the only allowcomments  value set to 1 is on the accesstype 'objectionable' for the page then only allow certain users (admins) to be allowed to leave a comment.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1310861/+subscriptions