mahara-contributors team mailing list archive

[Mahara Bot <1308294@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3266
Committed: http://gitorious.org/mahara/mahara/commit/e3cd08c6befe71131b1961fb8b0657efe361823c
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit e3cd08c6befe71131b1961fb8b0657efe361823c
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Wed Apr 16 12:48:25 2014 +1200

Making profile_icon_url()'s validation a little more logical

Bug 1308294: The code doesn't *really* need profileicon or email,
because it can always fall back to showing the anonymous user icon.
However, the lack of profileicon and email fields can indicating
a coding problem, so we should show a warning if they're missing.

Change-Id: I9926b7a4457049ef097e16d7999f109a623f2644

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1308294

Title:
  Error in profile_icon_url call

Status in Mahara ePortfolio:
  In Progress

Bug description:
  In htdocs/lib/user.php (approx line 2504) we have:

   if (!property_exists($user, 'profileicon') || !property_exists($user, 'email')) {
     ...
          log_debug("profile_icon_url was passed a user without profileicon & email properties");
     ...
   }

  The warn is for AND but the check is for OR.

  The check should be for AND.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1308294/+subscriptions