mahara-contributors team mailing list archive

[Mahara Bot <1307760@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3354
Committed: http://gitorious.org/mahara/mahara/commit/9aff53a4946e2570d486793169a1a0b4a0a5b45c
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    1.9_STABLE

commit 9aff53a4946e2570d486793169a1a0b4a0a5b45c
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Tue Apr 15 15:39:59 2014 +1200

Set default layout columns/widths hardcoded once (Bug #1307760)

And making sure that it exists in the db before using it.
This allows the fetching of the id of the default column widths to be
used in view layout page.

Also tidied up the js for the view layout page so it uses the value
from php rather than hardcoded string.

Also removed duplicate 'if (empty(self::$layoutcolumns)) { }'
statement from lib.view.php

Change-Id: Icf1b4292a256c5ff6d748c9e6046d6c71ea298b2
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1307760

Title:
  Problems saving view layout - no option selected by default

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.9 series:
  Fix Committed

Bug description:
  When I make a new page and click on the layout tab and then click save
  the system throws errors. This is due to no layout option being
  selected by default.

  If I selected 'advanced' or 'basic' sections then the 3 column layout
  get selected - but this is done in a less than optimal way as the
  value for the layout is hardcoded in the js so it is expecting that
  the layout option for the 3 column layout will have the id = 5, but
  this might not always be the case. We really need to find the default
  layout with php and pass the id to the js.

  Also in th js code there are js variables like $selected, which are
  written like they want to get the value from php.

  It would be better for the variables:
  - set by js to be written as 'var myvar ='
  - set by jquery/mochikit to be written as '$()' or '$j()' (where appropriate)
  - and have the php only be used on the right hand side of the sentance eg have 'var myvar = $phpvar'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1307760/+subscriptions